ArkefiToken Code Style Findings

ATN-01C: Redundant Separation of Unchecked Blocks

Type	Severity	Location
Code Style		ArkefiToken.sol:L107-L110, L111

Description:

The referenced unchecked blocks are sequential redundantly.

Example:

Copy
105for (uint256 i = 0; i < recipientsLength;) {
106    super._mint(recipients[i], values[i]);
107    unchecked {
108        // Overflow not possible: totalValue + amount is at most totalSupply + amount, which is checked above.
109        totalValue += values[i];
110    }
111    unchecked { i++; }
112}

Recommendation:

We advise a single unchecked block to be present that wraps all statements within each of the two distinct ones.

Alleviation:

The Arkefi team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.