Omniscia Boson Protocol Audit
MetaTransactionsHandlerFacet Code Style Findings
MetaTransactionsHandlerFacet Code Style Findings
MTH-01C: Non-Standard Specification of Version
| Type | Severity | Location |
|---|---|---|
| Code Style | ![]() | MetaTransactionsHandlerFacet.sol:L25 |
Description:
The referenced specification of the system's version (v2.4.0) is done so without the dot separator (i.e. v240) which is non-standard and ambiguous.
Example:
contracts/protocol/facets/MetaTransactionsHandlerFacet.sol
25) public onlyUninitialized(type(IBosonMetaTransactionsHandler).interfaceId ^ bytes4("v240")) {Recommendation:
We advise the dot to be introduced, ensuring that the version conforms to the semantic versioning system.
Alleviation:
The non-standard specification has been removed from the codebase rendering this exhibit no longer applicable.
