Omniscia Boson Protocol Audit
PauseHandlerFacet Code Style Findings
PauseHandlerFacet Code Style Findings
PHF-01C: Loop Iterator Optimizations
| Type | Severity | Location |
|---|---|---|
| Gas Optimization |  | PauseHandlerFacet.sol:L81, L87, L130 |
Description:
The linked for loops increment / decrement their iterator "safely" due to Solidity's built - in safe arithmetics (post-0.8.X).
Example:
contracts/protocol/facets/PauseHandlerFacet.sol
81for (uint256 i = 0; i < totalRegions; i++) {Recommendation:
We advise the increment / decrement operations to be performed in an unchecked code block as the last statement within each for loop to optimize their execution cost.
Alleviation (2b9f60b6c3323fd234b570089ceff924cdb5851c):
The referenced loop iterator increment statements have been properly relocated to the end of each for loop's body and wrapped in an unchecked code block, optimizing their execution cost.
PHF-02C: Redundant Parenthesis Statement
| Type | Severity | Location |
|---|---|---|
| Code Style | | PauseHandlerFacet.sol:L89 |
Description:
The referenced statement is redundantly wrapped in parenthesis (()).
Example:
contracts/protocol/facets/PauseHandlerFacet.sol
89if ((status.pauseScenario & (1 << i)) != 0) {Recommendation:
We advise them to be safely omitted, increasing the legibility of the codebase.
Alleviation (2b9f60b6c3323fd234b570089ceff924cdb5851c):
The redundant parenthesis statement has been safely omitted.