Omniscia Boson Protocol Audit
Code Style
Code Style
During the manual portion of the audit, we identified 36 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| BCS-01C |  |  | Generic Typographic Mistakes |
| BTS-01C | |  | Potentially Harmful Default Enum State |
| BVR-01C | | | Hard-Coded Interface Type |
| BBS-01C | | | Repetitive Invocations of Getter Function |
| BHF-01C | | | Unused Code |
| DLB-01C | | | Redundant Conditional Return Statement |
| DBE-01C | | | Repetitive Invocations of Getter Function |
| EIP-01C | | | Deprecated Chain ID Retrieval Code |
| EHF-01C | | | Multiple Top-Level Type Declarations |
| FHF-01C | | | Inefficient mapping Lookups |
| FHF-02C | | | Repetitive Invocations of Getter Functions |
| FHF-03C | | | Suboptimal Struct Declaration Style |
| FLB-01C | | | Ineffectual Usage of Safe Arithmetics |
| FLB-02C | | | Inefficient mapping Lookups |
| FLB-03C | | | Inexplicable Contract Specifier |
| GBE-01C | | | Repetitive Invocations of Getter Functions |
| GHF-01C | | | Inefficient mapping Lookups |
| GHF-02C | | | Repetitive Invocations of Getter Function |
| OBE-01C | | | Suboptimal Struct Declaration Style |
| CON-01C | | | Redundant Modifier Overlap |
| PBE-01C | | | Bytecode Size Optimization |
| PBE-02C | | | Potential Operator Optimization |
| PBS-01C | | | Repetitive Invocations of Getter Functions |
| PLB-01C | | | Generic Typographic Mistake |
| PLB-02C | | | Inefficient Data Types |
| RGB-01C | | | Outdated Documentation of Reentrancy Guard |
| SBE-01C | | | Multiple Top-Level Type Declarations |
| SBE-02C | | | Repetitive Invocations of Getter Functions |
| SHF-01C | | | Inefficient mapping Lookups |
| SHF-02C | | | Repetitive Invocations of Getter Function |
| TBE-01C | | | Hard-Coded Interface Types |
| TBE-02C | | | Inefficient Loop Limit Evaluations |
| TBE-03C | | | Inefficient mapping Lookups |
| TBE-04C | | | Repetitive Invocations of Getter Function |
| TBE-05C | | | Suboptimal Struct Declaration Type |
| THF-01C | | | Repetitive Invocations of Getter Function |