Omniscia Boson Protocol Audit
ClientProxy Static Analysis Findings
ClientProxy Static Analysis Findings
CPY-01S: Incorrect payable
Specifier
Type | Severity | Location |
---|---|---|
Language Specific | ![]() | ClientProxy.sol:L26-L30 |
Description:
The constructor
of the ClientProxy
contract is set as payable
incorrectly.
Impact:
Funds can currently be permanently locked in the contract in case they are sent during its construction.
Example:
contracts/protocol/clients/proxy/ClientProxy.sol
26constructor(27 address _accessController,28 address _protocolAddress,29 address _impl30) payable ClientExternalAddressesBase(_accessController, _protocolAddress, _impl) {}
Recommendation:
We advise the payable
modifier to be omitted avoiding lock of funds.
Alleviation (44009967e4f68092941d841e9e0f5dd2bb31bf0b):
The payable
specifier from the constructor
has been properly omitted from the codebase as advised.