Omniscia CloudFunding Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in CloudFunding's Flare-specific crowdfunding system.
As the project at hand implements a Flare Network-integrating system, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification as well as the recommended Flare Network integration mechanisms.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed a significant accounting vulnerability within the system's capital accounting module which could have had severe ramifications to its overall operation, however, it was conveyed ahead of time to the CloudFunding team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we advise the CloudFunding team to significantly expand the documentation surrounding the Flare Network integration along with relevant documentation that they consulted to build the ultimate product.
A total of 14 findings were identified over the course of the manual review of which 6 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
CAG-01M | Unsafe Delta Operations | ||
CFG-01M | Inexistent Graceful Handling of Rewards | ||
CFG-02M | Potentially Incorrect Epoch Assumption | ||
IOE-01M | Lock of EIP-20 Funds | ||
MAN-01M | Inexistent Removal Workflow | ||
MAN-02M | Potential of Duplicate FTSO Reward Entries |