Omniscia DAFI Audit
TVLFeeds Manual Review Findings
TVLFeeds Manual Review Findings
TVL-01M: Beta Functionality
| Type | Severity | Location |
|---|---|---|
| Logical Fault | Minor | [TVLFeeds.sol:L12](https://github.com/DAFIProtocol/dDAFI/blob/d08c795cdf3455616f403d1468e02ec234ab01ef/contracts/network demand/TVLFeeds.sol#L12), [L28](https://github.com/DAFIProtocol/dDAFI/blob/d08c795cdf3455616f403d1468e02ec234ab01ef/contracts/network demand/TVLFeeds.sol#L28) |
Description:
The TVLFeeds contract implementation is incomplete as it contains TODO comments denoting that it should be fleshed out once a certain feature is introduced in the Chainlink oracle service.
Example:
contracts/network
28function setGlobalTVL(uint _globalTVL) external onlyOwner{ //TODO Remove it when integrated with Chainlink aggregator29 globalTVL = _globalTVL;30}Recommendation:
We advise this contract to remain unutilized until the feature has been properly introduced and integrated with as it currently uses a completely centralized method for reporting the current TVL.
Alleviation:
The TVLFeeds contract will remain as is and the project stated that they will deploy with the price representing a 100% of the demand factor until the TVL metric is enabled at a later date.