DefaultPool Static Analysis Findings

DPL-01S: Inexistent Sanitization of Input Addresses

Type	Severity	Location
Input Sanitization		DefaultPool.sol:L36-L49

Description:

The linked function(s) accept address arguments yet do not properly sanitize them.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
36function setAddresses(address _vesselManagerAddress, address _activePoolAddress)
37    external
38    initializer
39{
40    require(!isInitialized, "Already initialized");
41    isInitialized = true;
42
43    __Ownable_init();
44
45    vesselManagerAddress = _vesselManagerAddress;
46    activePoolAddress = _activePoolAddress;
47
48    renounceOwnership();
49}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that each address specified is non-zero.

Alleviation:

The Gravita Protocol team has opted to not apply a remediation for this exhibit thus rendering it acknowledged.