Omniscia KlimaDAO Audit
KlimaCirculatingSupplyContract Code Style Findings
KlimaCirculatingSupplyContract Code Style Findings
KCS-01C: Inexistent Error Messages
| Type | Severity | Location |
|---|---|---|
| Code Style | Informational | KlimaCirculatingSupplyContract.sol:L303 |
Description:
The linked require checks have no error messages explicitly defined.
Example:
contracts/utils/KlimaCirculatingSupplyContract.sol
303require( isInitialized == false );Recommendation:
We advise them to be set so to aid in the validation of the require's condition as well as the legibility of the codebase.
Alleviation:
The KlimaDAO team considered this exhibit but opted to retain the codebase in its current state.
KCS-02C: Redundant SafeMath Utilization
| Type | Severity | Location |
|---|---|---|
| Gas Optimization | Informational | KlimaCirculatingSupplyContract.sol:L323 |
Description:
The i counter will always be within sensible uint256 bounds as it cannot exceed the length member of the array which itself is constrained within the uint256 spectrum.
Example:
contracts/utils/KlimaCirculatingSupplyContract.sol
323for( uint i=0; i < nonCirculatingKLIMAAddresses.length; i = i.add( 1 ) ) {Recommendation:
We advise the SafeMath usage to be omitted from this particular instance.
Alleviation:
The KlimaDAO team considered this exhibit but opted to retain the codebase in its current state.