Omniscia KlimaDAO Audit

AltExercisepKLIMA Static Analysis Findings

AltExercisepKLIMA Static Analysis Findings

AEK-01S: Inexistent Event Emission

TypeSeverityLocation
Language SpecificInformationalAltExercisepKLIMA.sol:L692-L704

Description:

The linked functions adjust sensitive contract variables.

Example:

contracts/pKLIMA/regular/AltExercisepKLIMA.sol
692function pushOwnership( address _newOwner ) external returns ( bool ) {
693    require( msg.sender == owner, "Sender is not owner" );
694    require( _newOwner != address(0) );
695    newOwner = _newOwner;
696    return true;
697}
698

699function pullOwnership() external returns ( bool ) {
700    require( msg.sender == newOwner );
701    owner = newOwner;
702    newOwner = address(0);
703    return true;
704}

Recommendation:

We advise events to be emitted for them to ensure off-chain processes can properly detect this change.

Alleviation:

Proper events were introduced for both actions.

Prev

AlphaKlimaRedeemUpgradeable.sol (AKR-S)

Next

ExercisepKLIMA.sol (EKL-S)

On this page