Omniscia Metavisor Audit

Code Style

Code Style

During the manual portion of the audit, we identified 11 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
ESR-01CPotential Error Usability Enhancements
MMV-01CInefficient Invocations of Getter Function
MRY-01CInefficient mapping Lookups
MRY-02CSimplification of Conditional
MRY-03CVariable Mutability Specifiers (Immutable)
UIH-01CImplied Order of Operations
UIH-02CImproper Negation of Values
UIH-03CIneffectual Usage of Safe Arithmetics
UIH-04CInefficient Boolean Argument
UIH-05CLiteral Value Presence
UIH-06CSuboptimal Struct Declaration Style