Omniscia Metavisor Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Metavisor's UniswapV3 vault implementation.
As the project at hand implements a complex DeFi liquidity provision mechanism, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple slippage-related vulnerabilities within the system which could have had severe ramifications to its overall operation, however, they were conveyed ahead of time to the Metavisor team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend it to be expanded at certain complex points such as the swap direction calculation and the optimal tick assessment based on this movement.
A total of 23 findings were identified over the course of the manual review of which 12 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| MMV-01M |  |  | Inexistent Conformity to Checks-Effects-Interactions Pattern |
| MMV-02M |  | | Unsafe Casting Operations |
| MMV-03M |  | | Inexistent Validation of Input / Output Amounts |
| MMV-04M | | | Slippage Prone Compounding Mechanism |
| MRY-01M | | | Inexistent Sanitization of Swap Percentage |
| MRY-02M | | | Inexistent Sanitization of Pool Validity |
| UIH-01M | | | Incorrect Tick Validation |
| UIH-02M | | | Unsafe Casting Operation |
| UIH-03M | |  | Incorrect Calculation of Next Price |
| UIH-04M | | | Incorrect Price Impact Assessment |
| UIH-05M | | | Incorrect Price Utilization |
| UIH-06M |  | | Flash-Loan Price Manipulation Susceptibility |