SupplyVaultUpgradeable Static Analysis Findings

SVU-01S: Inexistent Sanitization of Input Addresses

Type	Severity	Location
Input Sanitization		SupplyVaultUpgradeable.sol:L46, L47, L80

Description:

The linked function(s) accept address arguments yet do not properly sanitize them.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
80function setRewardsController(address _rewardsController) external onlyOwner {
81    rewardsController = IRewardsController(_rewardsController);
82    emit RewardsControllerSet(_rewardsController);
83}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that each address specified is non-zero.

Alleviation:

The last referenced input argument is no longer present in the codebase, however, the first two linked arguments are now properly sanitized thus addressing this exhibit in full.