Omniscia Nuklai Protocol Audit
NuklaiToken Manual Review Findings
NuklaiToken Manual Review Findings
NTN-01M: Non-Standard Disable of Initializers
Type | Severity | Location |
---|---|---|
Standard Conformity | ![]() | NuklaiToken.sol:L16 |
Description:
The NuklaiToken
will disable its Initializable
initializers by invoking the Initializable::initializer
modifier which is non-standard and will not disable certain initialization patterns (i.e. versioned ones) in recent OpenZeppelin versions.
Impact:
While the Initializable
dependency is not properly disabled, the current disable mechanism is sufficient as the NuklaiToken
does not support versioned initializations (i.e. Initializable::reinitializer
).
As such, the severity of this exhibit is merely informational.
Example:
16constructor() initializer {}
Recommendation:
We advise the Initializable::_disableInitializers
function to be invoked instead during the contract's NuklaiToken::constructor
, ensuring that all types of initializations are disabled for the NuklaiToken
logic contract.
Alleviation:
The Nuklai team evaluated this exhibit but opted not to apply a remediation for it as the Nuklai token is already deployed. Given that the exhibit is of informational nature, we consider it safely acknowledged.