Position Static Analysis Findings

PNO-01S: Tautological Comparison

Type	Severity	Location
Gas Optimization		Position.sol:L54

Description:

The referenced if statement will evaluate whether an unsigned integer is less-than-or-equal-to zero.

Example:

Copy
54if (_self.liquidity <= 0) revert NP(); // disallow pokes for 0 liquidity positions

Recommendation:

We advise it to be converted to an equality operator as an unsigned integer cannot be negative (i.e. less-than zero).

Alleviation (3248d1d2fdfa6e1e270ff27db8eefb13dcb55c40):

The referenced tautological comparison was corrected to simply evaluate an equality with 0, addressing this exhibit.