Omniscia SaucerSwap Labs Audit
Router Implementation Security Audit
Audit Report Revisions
| Commit Hash | Date | Audit Report Hash |
|---|---|---|
| 3bcac28ac5 | May 18th 2023 | 547ef8efa5 |
| a2c5a0b913 | June 4th 2023 | 34b18eef78 |
| fd26dbdf6d | June 7th 2023 | b99e9fa33c |
Audit Overview
We were tasked with performing an audit of the SaucerSwap Labs codebase and in particular their Uniswap-integrating router implementation meant to be deployed in the Hedera Network ecosystem.
Over the course of the audit, we identified a major vulnerability in the router's exchange flow when the output is in ETH as the wHBAR unwrapping mechanism is improperly integrated with.
We advise the SaucerSwap Labs team to closely evaluate all minor-and-above findings identified in the report and promptly remediate them as well as consider all optimizational exhibits identified in the report.
Post-Audit Conclusion
The SaucerSwap Labs team iterated through all findings within the report and provided us with a revised commit hash to evaluate all exhibits on.
We evaluated all alleviations performed by SaucerSwap Labs and have identified that certain exhibits have not been adequately dealt with. We advise the SaucerSwap Labs team to revisit the following exhibit: UVR-01M
Additionally, the following informational exhibit was partially alleviated and requires further action: HTS-01S
Post-Audit Conclusion (fd26dbdf6d)
The SaucerSwap team revisited the two remaining exhibits and carried out the correct remediation action for each of them.
As a result, all exhibits of the report have been adequately dealt with and the outputs of the report have been properly consumed by the SaucerSwap team.
Contracts Assessed
| Files in Scope | Repository | Commit(s) |
|---|---|---|
| Bits.sol (BST) | saucerswap-core | 3bcac28ac5, a2c5a0b913, fd26dbdf6d |
| HederaTokenService.sol (HTS) | saucerswap-core | 3bcac28ac5, a2c5a0b913, fd26dbdf6d |
| HederaResponseCodes.sol (HRC) | saucerswap-core | 3bcac28ac5, a2c5a0b913, fd26dbdf6d |
| Math.sol (MHT) | saucerswap-core | 3bcac28ac5, a2c5a0b913, fd26dbdf6d |
| SafeCast.sol (SCT) | saucerswap-core | 3bcac28ac5, a2c5a0b913, fd26dbdf6d |
| SafeMath.sol (SMH) | saucerswap-core | 3bcac28ac5, a2c5a0b913, fd26dbdf6d |
| SafeHederaTokenService.sol (SHT) | saucerswap-core | 3bcac28ac5, a2c5a0b913, fd26dbdf6d |
| TransferHelper.sol (THR) | saucerswap-core | 3bcac28ac5, a2c5a0b913, fd26dbdf6d |
| UQ112x112.sol (UQ2) | saucerswap-core | 3bcac28ac5, a2c5a0b913, fd26dbdf6d |
| UniswapV2Library.sol (UVL) | saucerswap-core | 3bcac28ac5, a2c5a0b913, fd26dbdf6d |
| UniswapV2Router02.sol (UVR) | saucerswap-core | 3bcac28ac5, a2c5a0b913, fd26dbdf6d |
Audit Synopsis
| Severity | Identified | Alleviated | Partially Alleviated | Acknowledged |
|---|---|---|---|---|
 | 0 | 0 | 0 | 0 |
 | 8 | 8 | 0 | 0 |
 | 1 | 1 | 0 | 0 |
 | 2 | 2 | 0 | 0 |
 | 1 | 1 | 0 | 0 |
During the audit, we filtered and validated a total of 1 findings utilizing static analysis tools as well as identified a total of 11 findings during the manual review of the codebase. We strongly recommend that any minor severity or higher findings are dealt with promptly prior to the project's launch as they can introduce potential misbehaviours of the system as well as exploits.
The list below covers each segment of the audit in depth and links to the respective chapter of the report: