LiquidityManagerVault Code Style Findings

LMV-01C: Ineffectual Usage of Safe Arithmetics

Type	Severity	Location
Language Specific		LiquidityManagerVault.sol: • I-1: L350 • I-2: L351 • I-3: L736 • I-4: L737

Description:

The linked mathematical operations are guaranteed to be performed safely by surrounding conditionals evaluated in either require checks or if-else constructs.

Example:

Copy
350amount0 = vaultBalance0After > vaultBalance0Before ? vaultBalance0After - vaultBalance0Before : 0;

Recommendation:

Given that safe arithmetics are toggled on by default in pragma versions of 0.8.X, we advise the linked statements to be wrapped in unchecked code blocks thereby optimizing their execution cost.

Alleviation:

The Steer Protocol team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.