Omniscia Steer Protocol Audit

VaultRegistry Static Analysis Findings

VaultRegistry Static Analysis Findings

VRY-01S: Inexistent Event Emissions

TypeSeverityLocation
Language SpecificVaultRegistry.sol:
I-1: L467-L470
I-2: L472-L474
I-3: L476-L478

Description:

The linked functions adjust sensitive contract variables yet do not emit an event for it.

Example:

contracts/VaultRegistry.sol
472function setVaultHelper(address _vaultHelper) external onlyOwner {
473 vaultHelper = _vaultHelper;
474}

Recommendation:

We advise an event to be declared and correspondingly emitted for each function to ensure off-chain processes can properly react to this system adjustment.

Alleviation (fbb15dfb5e):

An event emission was properly introduced to the second (I-2) of the three instances, rendering this exhibit partially addressed.

Alleviation (5dd0f3897b):

Proper event emissions have been introduced for the two remaining instances rendering this exhibit fully addressed.