Portal Static Analysis Findings

POR-01S: Leftover TODO Comment

Type	Severity	Location
Code Style		Portal.sol:L301

Description:

The linked TODO comment indicates code that has not been clearly defined.

Example:

Copy
298emit RevertSynthesizeCompleted(
299    _txID,
300    txState.recipient,
301    txState.amount, // TODO: which amount?
302    txState.rtoken
303);

Recommendation:

We advise the proper amount event argument to be assessed, assimilated in the codebase and the comment to be removed.

Alleviation:

The amount argument was instead adjusted to one accounting for the stable bridging fee and the stable bridging fee is now minted along the RevertSynthesizeCompleted event.

POR-02S: Variable Shadowing

Type	Severity	Location
Language Specific		Portal.sol:L100, L229

Description:

The linked variables cause a naming colission with equivalent-name variables in inherited implementations.

Example:

Copy
100address _trustedForwarder,

Recommendation:

We advise them to be renamed to avoid the colission and potentially undefined code behaviour.

Alleviation:

The Symbiosis Finance team considered this exhibit but opted not to apply a remediation for it in the current iteration.