Omniscia Symbiosis Finance Audit
SyntFabric Code Style Findings
SyntFabric Code Style Findings
SFC-01C: Inexistent Error Messages
| Type | Severity | Location |
|---|---|---|
| Code Style | ![]() | SyntFabric.sol:L32 |
Description:
The linked require checks have no error messages explicitly defined.
Example:
contracts/synth-contracts/SyntFabric.sol
32require(msg.sender == synthesis);Recommendation:
We advise them to be set so to aid in the validation of the require's condition as well as the legibility of the codebase.
Alleviation:
A proper error message was introduced for the linked instance.
SFC-02C: Inexistent Function Implementations
| Type | Severity | Location |
|---|---|---|
| Code Style | ![]() | SyntFabric.sol:L217, L218 |
Description:
The code specification mentions functions that are no longer part of the codebase.
Example:
contracts/synth-contracts/SyntFabric.sol
215/**216 * @dev Sets representation217 * @dev Internal function used in createRepresentationByAdmin, createRepresentationByTokenOwner,218 * createRepresentationByTokenOwnerSalted219 */Recommendation:
We advise the comments to be revised to no longer mention deprecated code.
Alleviation:
The Symbiosis Finance team considered this exhibit but opted not to apply a remediation for it in the current iteration.
