Omniscia Symbiosis Finance Audit
MetaRouterV2 Code Style Findings
MetaRouterV2 Code Style Findings
MRV-01C: Data Location Optimization
| Type | Severity | Location |
|---|---|---|
| Gas Optimization | ![]() | MetaRouterV2.sol:L19, L95, L102 |
Description:
The linked function arguments are set as memory yet are declared in external functions.
Example:
contracts/metarouter/MetaRouterV2.sol
101function metaMintSwap(102 MetaRouteStructs.MetaMintTransaction memory _metaMintTransaction103) external {Recommendation:
We advise them to be set as calldata optimizing their read-access gas cost.
Alleviation:
All linked instances were properly adjusted to calldata.
MRV-02C: Redundant constructor Implementation
| Type | Severity | Location |
|---|---|---|
| Gas Optimization | ![]() | MetaRouterV2.sol:L16 |
Description:
The linked constructor is redundant.
Example:
contracts/metarouter/MetaRouterV2.sol
16constructor() public {}Recommendation:
We advise it to be omitted from the codebase.
Alleviation:
The constructor function has been omitted from the codebase as per our recommendation.
