Omniscia Tozex Audit
MultiSigWallet Static Analysis Findings
MultiSigWallet Static Analysis Findings
MSW-01S: Literal Equality of bool
Variable
Type | Severity | Location |
---|---|---|
Gas Optimization | ![]() | MultiSigWallet.sol:L161 |
Description:
The linked bool
comparison is performed between a variable and a bool
literal.
Example:
contracts/MultiSigWallet/MultiSigWallet.sol
161require(isSigner[_newSigner] == false, "New signer is already a signer.");
Recommendation:
We advise the bool
variable to be utilized directly either in its negated (!
) or original form.
Alleviation (4f28adbafcd4899bf095e7df054499a7d9839444):
The isSigner[_newSigner]
boolean evaluation is now properly utilized directly in its negated form (!
) instead of comparing it to the false
variable with an equality, addressing this exhibit.