Omniscia Stakewise Audit
Code Style
Code Style
During the manual portion of the audit, we identified 15 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| ERP-01C | Informational | No | Sub-Optimal EIP-712 Implementation |
| ERP-02C | Informational | No | Unoptimized Variable Mutability |
| ERC-01C | Informational | No | Deprecated Maximum Representation Style |
| ORA-01C | Informational | Yes | Inefficient Block Number Comparison |
| ORA-02C | Informational | Yes | Multiple Top-Level Declarations |
| ORA-03C | Informational | No | Redundant Visibility Specifier |
| ORA-04C | Informational | Yes | Undocumented Consortium Level |
| OPE-01C | Informational | No | Redundant Visibility Specifier |
| OPU-01C | Informational | No | Redundant Visibility Specifier |
| POO-01C | Informational | Yes | Undocumented Value Literal |
| PVS-01C | Informational | No | Redundant Root Validations |
| RET-01C | Informational | Yes | Duplicate Event Emittance & Storage Write |
| ROL-01C | Informational | Yes | Unspecified Numerical Accuracy |
| SET-01C | Informational | No | Incorrect Gas Optimization |
| SET-02C | Informational | No | Potential XOR Optimization |