Omniscia Stakewise Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the ETH2 stakign implementation of Stakewise.
As the project at hand implements an ETH2 staking solution, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth both within the protocol's specification as well as the ETH2 protocol it is interfacing with.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple misbehaviours within the system including one which could have had severe ramifications to its overall operation, however, they were conveyed ahead of time to the Stakewise team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend the documentation of the project to be expanded at certain ambiguous points such as the numeric literals utilized across it.
A total of 26 findings were identified over the course of the manual review of which 11 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| ERP-01M | Minor | No | Non-Standard Upgradeable Initialization Pattern |
| MDR-01M | Minor | Yes | Improper Pause State Access Control |
| MDR-02M | Minor | Yes | Ineffectual Duration Argument |
| MDR-03M | Minor | Yes | Potentially Unclaimed Rewards |
| MDR-04M | Informational | Yes | Potential Claim Race Condition |
| ORA-01M | Medium | Yes | Inexistent Validation of Signature Payload Submitter |
| ORA-02M | Medium | Yes | Single Point of Failure |
| POO-01M | Minor | Yes | Inexistent Validation of Amount |
| PVS-01M | Minor | Yes | Inexistent Removal of Validator Status |
| RET-01M | Major | Yes | Circumvention of Checkpointing Mechanism |
| ROL-01M | Minor | No | Event-Based Role Management |