Omniscia Transient Audit

TSCPool Code Style Findings

TSCPool Code Style Findings

TSP-01C: Redundant Secondary Event Index

TypeSeverityLocation
Language SpecificInformationalTSCPool.sol:L7

Description:

The _contracts variable of the Created event is redundantly indexed as it will be unique per call.

Example:

tsc-contracts/contracts/TSCPool.sol
7event Created(address indexed _creator, address indexed _contracts);
8
9function create(
10) public returns(address) {
11 TSC contracts = new TSC();
12 contracts.transferOwnership(msg.sender);
13 emit Created(msg.sender, address(contracts));
14 return address(contracts);
15}

Recommendation:

We advise indexing to be omitted from it.

Alleviation:

The indexed keyword was properly omitted from the event.