Omniscia Transient Audit

Manual Review

Manual Review

A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the multi-asset expire-able deposit and transfer system of Transient.

As the project at hand implements an expiration workflow with multiple assets native and non-native in escrow, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.

We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple vulnerabilities within the system which could have had severe ramifications to its overall operation, however, they were conveyed ahead of time to the Transient team to be promptly remediated.

Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend the documentation of the project to be expanded at certain complex points such as the rationale behind the system's complex state machine.

A total of 14 findings were identified over the course of the manual review of which 12 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.

The finding table below enumerates all these security / behavioural findings:

IDSeverityAddressedTitle
OWN-01MMinorYesPull-Over-Push Pattern
TSC-01MMajorYesInexistent Overriddence of Parent Functionality
TSC-02MMediumYesDeprecated Native Transfer
TSC-03MMediumNoImproper Native ETH Accounting
TSC-04MMediumYesImproper Usage of ERC-20 transfer / transferFrom
TSC-05MMediumYesInexistent Validation of Failed Signature Recovery
TSC-06MMediumYesInexistent Validation of Pre-Existing Entries
TSC-07MMediumYesInexistent Validation of Signature Malleability
TSC-08MMinorYesDisregard of Token Fees
TSC-09MMinorYesFund Management Discrepancy
TCT-01MMediumNoInexistent Reset Protection
TCT-02MMinorYesImproper State Validation