Omniscia Transient Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the multi-asset expire-able deposit and transfer system of Transient.
As the project at hand implements an expiration workflow with multiple assets native and non-native in escrow, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple vulnerabilities within the system which could have had severe ramifications to its overall operation, however, they were conveyed ahead of time to the Transient team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend the documentation of the project to be expanded at certain complex points such as the rationale behind the system's complex state machine.
A total of 14 findings were identified over the course of the manual review of which 12 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
OWN-01M | Minor | Yes | Pull-Over-Push Pattern |
TSC-01M | Major | Yes | Inexistent Overriddence of Parent Functionality |
TSC-02M | Medium | Yes | Deprecated Native Transfer |
TSC-03M | Medium | No | Improper Native ETH Accounting |
TSC-04M | Medium | Yes | Improper Usage of ERC-20 transfer / transferFrom |
TSC-05M | Medium | Yes | Inexistent Validation of Failed Signature Recovery |
TSC-06M | Medium | Yes | Inexistent Validation of Pre-Existing Entries |
TSC-07M | Medium | Yes | Inexistent Validation of Signature Malleability |
TSC-08M | Minor | Yes | Disregard of Token Fees |
TSC-09M | Minor | Yes | Fund Management Discrepancy |
TCT-01M | Medium | No | Inexistent Reset Protection |
TCT-02M | Minor | Yes | Improper State Validation |