Omniscia Echidna Finance Audit
Code Style
Code Style
During the manual portion of the audit, we identified 27 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| BOO-01C | Informational | Yes | Deprecated if-revert Pattern |
| BOO-02C | Informational | Yes | Inefficient Data Location Specifier |
| BOO-03C | Informational | Yes | Inefficient Execution Guard |
| BOO-04C | Informational | Yes | Inefficient Execution of Incentive Distribution |
| BOO-05C | Informational | Yes | Inexistent Error Message |
| BOO-06C | Informational | Yes | Inexistent Visibility Specifiers |
| BOO-07C | Informational | Yes | Variable Mutability Specifiers |
| EPS-01C | Informational | Yes | Inexistent Mutability Specifiers |
| EPT-01C | Informational | Yes | Inexistent Error Message |
| ETN-01C | Informational | Yes | Convoluted Initial Cap Representation |
| ETN-02C | Informational | Yes | Inexistent Error Messages |
| ETN-03C | Informational | Yes | Variable Mutability Specifiers |
| MDR-01C | Informational | Yes | Inexistent Error Message |
| MDR-02C | Informational | Yes | Redundant Contract Variable |
| MDR-03C | Informational | Yes | Variable Mutability Specifiers |
| PPY-01C | Informational | Yes | Inefficient Upgradeable Storage Layout |
| PPY-02C | Informational | Yes | Inexistent Error Messages |
| PPY-03C | Informational | Yes | Redundant Input Argument Declaration |
| PFY-01C | Informational | Yes | Improperly Attributed Code |
| PDR-01C | Informational | Yes | Function Typo |
| PDR-02C | Informational | Yes | Inexistent Error Messages |
| PDR-03C | Informational | Yes | Inexistent Visibility Specifiers |
| PDR-04C | Informational | Yes | Variable Mutability Specifiers |
| RFY-01C | Informational | Yes | Inexistent Error Messages |
| RFY-02C | Informational | Yes | Inexistent Visibility Specifier |
| RFY-03C | Informational | No | Variable Mutability Specifiers |
| VER-01C | Informational | Yes | Variable Mutability Specifiers |