Omniscia Echidna Finance Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the complex staking system of Echidna.
As the project at hand implements a Platypus-interfacing staking protocol, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within both protocols' specifications.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple major vulnerabilities within the system which could have had severe ramifications to its overall operation, however, they were conveyed ahead of time to the Echidna team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend the documentation of the project to be expanded at certain complex points such as the VeEcd
interactions of the VeEcdRewardsPool
implementation.
A total of 47 findings were identified over the course of the manual review of which 20 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
BOO-01M | Minor | Yes | Deprecated Approval Paradigm |
BOO-02M | Minor | Yes | Improper Approval Assignment |
EPS-01M | Minor | Yes | Improper Commit Mechanism |
EPT-01M | Major | Yes | Improper Initialize Pattern |
ETN-01M | Minor | Yes | Improper Commit Mechanism |
ETN-02M | Minor | Yes | Inexistent Validation of Inflation Rate |
MDR-01M | Minor | No | Improper Execution Guards of claimQuit |
MDR-02M | Minor | Yes | Potential Share Value Truncation |
PPY-01M | Major | Yes | Overly Centralized Functionality |
PPY-02M | Medium | Yes | Improper Approval Assignment |
PPY-03M | Minor | Yes | Deprecated Approval Paradigm |
PPY-04M | Minor | Yes | Improper Commit Mechanism |
PPY-05M | Minor | Yes | Inexistent Clearance of Next Entry |
PDR-01M | Minor | Yes | Deprecated Approval Paradigm |
PDR-02M | Minor | Yes | Improperly Decentralized Functionality |
RFY-01M | Minor | No | Redundant Re-Invocation Capability |
RPL-01M | Major | Yes | Improper Unstaking Reward Tracking |
VER-01M | Minor | Yes | Arbitrary Account Staking |
VER-02M | Minor | Yes | Deprecated Approval Paradigm |
VBR-01M | Major | Yes | Inexistent Prevention of Re-Initialization |