Omniscia Echidna Finance Audit

Manual Review

Manual Review

A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the complex staking system of Echidna.

As the project at hand implements a Platypus-interfacing staking protocol, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within both protocols' specifications.

We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple major vulnerabilities within the system which could have had severe ramifications to its overall operation, however, they were conveyed ahead of time to the Echidna team to be promptly remediated.

Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend the documentation of the project to be expanded at certain complex points such as the VeEcd interactions of the VeEcdRewardsPool implementation.

A total of 47 findings were identified over the course of the manual review of which 20 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.

The finding table below enumerates all these security / behavioural findings:

IDSeverityAddressedTitle
BOO-01MMinorYesDeprecated Approval Paradigm
BOO-02MMinorYesImproper Approval Assignment
EPS-01MMinorYesImproper Commit Mechanism
EPT-01MMajorYesImproper Initialize Pattern
ETN-01MMinorYesImproper Commit Mechanism
ETN-02MMinorYesInexistent Validation of Inflation Rate
MDR-01MMinorNoImproper Execution Guards of claimQuit
MDR-02MMinorYesPotential Share Value Truncation
PPY-01MMajorYesOverly Centralized Functionality
PPY-02MMediumYesImproper Approval Assignment
PPY-03MMinorYesDeprecated Approval Paradigm
PPY-04MMinorYesImproper Commit Mechanism
PPY-05MMinorYesInexistent Clearance of Next Entry
PDR-01MMinorYesDeprecated Approval Paradigm
PDR-02MMinorYesImproperly Decentralized Functionality
RFY-01MMinorNoRedundant Re-Invocation Capability
RPL-01MMajorYesImproper Unstaking Reward Tracking
VER-01MMinorYesArbitrary Account Staking
VER-02MMinorYesDeprecated Approval Paradigm
VBR-01MMajorYesInexistent Prevention of Re-Initialization