Omniscia Echidna Finance Audit

VeEcdRewardsPool Code Style Findings

VeEcdRewardsPool Code Style Findings

VER-01C: Variable Mutability Specifiers

Description:

The linked variables are assigned to only once during the contract's constructor.

Example:

contracts/rewards/VeEcdRewardsPool.sol
48constructor(
49    address veToken_,
50    address rewardToken_,
51    address _ptpDepositor,
52    address _ecdPtpRewardPool,
53    address _ecdPtpToken
54) {
55    veToken = IERC20(veToken_);
56    rewardToken = IERC20(rewardToken_);
57    ptpDepositor = _ptpDepositor;
58    ecdPtpRewardPool = _ecdPtpRewardPool;
59    ecdPtpToken = IERC20(_ecdPtpToken);
60}

Recommendation:

We advise them to be set as immutable greatly optimizing the codebase.

Alleviation:

All linked variables were properly set as immutable.

Prev

RewardFactory.sol (RFY-C)

Next

Finding Types

On this page