Omniscia LOC Game Audit

LOCAccess Code Style Findings

LOCAccess Code Style Findings

LOC-01C: Redundant Visibility Specifier

TypeSeverityLocation
Gas OptimizationInformationalLOCAccess.sol:L7

Description:

The linked variable is a contract-level constant and is declared as public.

Example:

contracts/LOCAccess.sol
7bytes32 public constant MINTER_ROLE = keccak256("MINTER_ROLE");

Recommendation:

We advise it to be set as internal given that it has no use outside of the contract and produces redundant bytecode increasing the gas cost of deployment unnecessarily.

Alleviation:

The variable visibility was deemed desirable by the LOC Game team and as such no change was performed to alleviate this exhibit.