Omniscia LOC Game Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in the NFT implementation of LOCG.
As the project at hand implements an NFT, intricate care was put into ensuring that the implementation is compliant with the ERC standards it implements and that the minting process is in line with the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed weak access control in an important function as well as an inexistent sanity check within the minting system, however, they were conveyed ahead of time to the LOC Game team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend the documentation of the project to be expanded at certain complex points such as the way the card collections / IDs are meant to behave.
A total of 7 findings were identified over the course of the manual review of which 2 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
LOG-01M | Medium | Yes | Inexistent Validation of Card Collection Supply |
LOO-01M | Minor | Yes | Weak Access Control |