Omniscia LOC Game Audit
LOCGamePlayNFT Static Analysis Findings
LOCGamePlayNFT Static Analysis Findings
LOG-01S: Function Visibility Optimization
Type | Severity | Location |
---|---|---|
Gas Optimization | Informational | LOCGamePlayNFT.sol:L29-L30 |
Description:
The linked function contains a memory
argument, is not used internally in the codebase and is declared as public
.
Example:
contracts/LOCGamePlayNFT.sol
29function mintBatch(address to, uint256[] memory tokenIds)30 public
Recommendation:
We advise its visibility to be set to external
and its argument as calldata
greatly optimizing the codebase.
Alleviation:
The function was properly set to external
and its argument to calldata
thereby alleviating this exhibit.