Omniscia MetaSoccer Audit

Code Style

Code Style

During the manual portion of the audit, we identified 11 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
EMR-01CIllegible Struct Initialization
ESE-01CStruct Mutability Optimization
MSP-01CInefficient Dynamic Evaluation of Loop Limit
MSP-02CRedundant Variable Visibility
MSS-01CIllegible Struct Initialization
MSS-02CInefficient Loop Limit Evaluations
MSS-03CInefficient Seed Offset Storing
MSS-04CInexistent Visibility Specifier
MSS-05CVariable Mutability Specifiers
PIG-01CDeprecated if-revert Pattern
TWW-01CInefficient Usage of Dependency