Omniscia MetaSoccer Audit

PlayersIdGenerator Static Analysis Findings

PlayersIdGenerator Static Analysis Findings

PIG-01S: Unusued Function Variable

Description:

The _minterId variable remains unused in the function.

Example:

contracts/PlayersIdGenerator.sol
20function getPlayerId(uint256 _minterType, uint256 _minterId, uint256 _totalSupply) public pure returns (uint256) {

Recommendation:

We advise its name to be omitted from the function signature while its data type remains as advised by the compiler (i.e. test(uint256 foo, uint256 bar) would become test(uint256, uint256 bar)).

Alleviation:

The exhibit is acknowledged by the Metasoccer team but no remediation will be applied as they wish to retain increased legibility in the codebase for potential future upgrades.