Omniscia MetaSoccer Audit
MetaSoccerPlayers Static Analysis Findings
MetaSoccerPlayers Static Analysis Findings
MSP-01S: Inexistent Validation of Input Address
Type | Severity | Location |
---|---|---|
Input Sanitization | MetaSoccerPlayers.sol:L105-L107 |
Description:
The linked function accepts an address
argument yet does not sanitize it.
Example:
contracts/MetaSoccerPlayers.sol
105function setIdGenerator(address _newIdGenerator) external onlyRole(DEFAULT_ADMIN_ROLE) {106 idGenerator = IPlayersIdGenerator(_newIdGenerator);107}
Recommendation:
We advise it to be compared against the zero-address to prevent incorrect invocations of the function.
Alleviation:
The input argument is now properly sanitized.