Omniscia Olive Audit

Code Style

Code Style

During the manual portion of the audit, we identified 10 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
MAN-01CInefficient Re-Entrancy Guard
MAN-02CInefficient Utilization of Length
MAN-03CRedundant Usage of SafeMath
POO-01CInefficient Re-Entrancy Guard
POO-02CRedundant Usage of SafeMath
REW-01CRedundant Usage of SafeMath
RHH-01CIneffectual constructor Implementation
RHH-02CRedundant Usage of SafeMath
STA-01CRedundant Usage of SafeMath
VOE-01CRedundant Variable Visibility