Omniscia Olive Audit
Pool Static Analysis Findings
Pool Static Analysis Findings
POO-01S: Variable Shadowing
Type | Severity | Location |
---|---|---|
Language Specific | Pool.sol:L46, L47 |
Description:
The linked variables shadow existing declarations in parent contracts.
Example:
contracts/pools/Pool.sol
43function initialize(44 ERC20 _underlyer,45 IManager _manager,46 string memory _name,47 string memory _symbol48) public initializer {
Recommendation:
We advise them to be renamed to avoid the name collision by i.e. prefixing or suffixing with an underscore (_
).
Alleviation:
The variable shadowing has been corrected by renaming the linked variables as advised.