Manual Review

A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Olive's protocol implementation.

As the project at hand implements a governance, staking and reward claim mechanism, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.

We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed certain misbehaviours within the system which could have had moderate to severe ramifications to its overall operation if misused, however, they were conveyed ahead of time to the Olive Protocol team to be promptly remediated.

Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to the extent it need be, however, the voting structure of the project is complex and we advise a simpler solution to be opted for use.

A total of 18 findings were identified over the course of the manual review of which 8 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.

The finding table below enumerates all these security / behavioural findings:

ID	Severity	Addressed	Title
MAN-01M			Mismatch of Access Control
MAN-02M			Improper Utilization of Duration
MAN-03M			Inexistent Rollover State Validation
MAN-04M			Inexplicable Re-Invocation Capability
POO-01M			Potentially Improper Balance Relay
RHH-01M			Inexistent Validation of Existing Entry
VOE-01M			System Voting Power Desynchronization
VOE-02M			Inexistent Access Control of Event Emission