Omniscia Avant Protocol Audit
Code Style
Code Style
During the manual portion of the audit, we identified 18 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| AUS-01C |  |  | Generic Typographic Mistake |
| AUS-02C | | | Inefficient Ownership Transfer |
| AUS-03C | | | Non-Standard Order of Arguments |
| AUM-01C | | | Inefficient Event Emissions |
| AUM-02C | | | Inefficient Remainder Transfer |
| AUM-03C | |  | Inefficient Split of Logic |
| AUM-04C | | | Inefficient mapping Lookups |
| AUM-05C | | | Non-Standard Modifier Structure |
| AUM-06C | | | Non-Standard Negation of Conditional |
| AUM-07C | | | Potentially Improper Role Assignment |
| AUM-08C | | | Redundant Condition |
| AUM-09C | | | Redundant Duplication of Code |
| AUM-10C | | | Redundant Parenthesis Statement |
| SAA-01C | | | Inefficient Duplicate Read of Variable |
| SAA-02C | | | Inefficient Initial Ownership |
| SAU-01C | | | Redundant Parenthesis Statement |
| SAS-01C | | | Inefficient Event Emittance |
| SAS-02C | | | Inefficient mapping Lookups |