Omniscia Avocado Fund Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Avocado Fund's lending and staking system.
As the project at hand implements a combination of a lending and staking system, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple significant vulnerabilities within the system which could have had severe ramifications to its overall operation; for more information, kindly consult the relevant non-informational exhibits within the audit report.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a great extent, containing extensive in-line documentation as well as function NatSpec definitions.
A total of 18 findings were identified over the course of the manual review of which 13 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| ALG-01M |  |  | Inexistent Slippage Control of Borrow Rate |
| ALG-02M | | | Unsustainable Iteration Approach |
| ALG-03M |  | | Arbitrary Loan Borrow Rate |
| ALG-04M | | | Incorrect Loan Repayment Tracking |
| ALG-05M |  | | Incorrect Interest Accrual |
| ALG-06M | | | Incorrect Mass Interest Accrual |
| AVT-01M |  | | Incorrect Cap Assumption |
| AVT-02M | | | Improper Performance Fee Adjustment |
| AVT-03M | | | Inexistent Access Control of Fee Collection |
| AVT-04M | | | Incorrect Handling of Interest |
| VRS-01M | | | Inexistent Saturating Subtraction of Emergency Mechanism |
| VRS-02M | | | Inexistent Handling of Cap Breach |
| VRS-03M | | | Insecure Boost System |