AvocadoLending Static Analysis Findings

ALG-01S: Illegible Numeric Value Representations

Type	Severity	Location
Code Style		AvocadoLending.sol: • I-1: L33 • I-2: L34

Description:

The linked representations of numeric literals are sub-optimally represented decreasing the legibility of the codebase.

Example:

Copy
33uint256 public constant BPS_DENOMINATOR    = 10_000;

Recommendation:

To properly illustrate each value's purpose, we advise the following guidelines to be followed. For values meant to depict fractions with a base of 1e18, we advise fractions to be utilized directly (i.e. 1e17 becomes 0.1e18) as they are supported. For values meant to represent a percentage base, we advise each value to utilize the underscore (_) separator to discern the percentage decimal (i.e. 10000 becomes 100_00, 300 becomes 3_00 and so on). Finally, for large numeric values we simply advise the underscore character to be utilized again to represent them (i.e. 1000000 becomes 1_000_000).

Alleviation (a859cd2191d509cbc6d47508bdd44ec6d3cc9844):

The percentage values referenced have been properly updated to 100_00 and 50_00, addressing this exhibit.

ALG-02S: Unused Local Variable

Type	Severity	Location
Code Style		AvocadoLending.sol:L120

Description:

The referenced variable remains unused.

Example:

Copy
120uint256 available = vaultDeployed == 0 ? vaultIdle : usdc.balanceOf(address(this));

Recommendation:

We advise it to be omitted, optimizing the code's gas cost.

Alleviation (a859cd2191d509cbc6d47508bdd44ec6d3cc9844):

The unused available local variable has been omitted as recommended.