Omniscia Boson Protocol Audit

Code Style

Code Style

During the manual portion of the audit, we identified 12 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
ECB-01CUnconditional Discard of Transient Queue
ERB-01CBPIP-13 Mismatch of Voucher Burning Approach
FBE-01CInconsistent SPDX License Specifier
FBE-02CUnconditional Discard of Transient Queue
MTH-01CBPIP-12 Function Signature Mismatch
OH2-01CGeneric Typographic Mistake
TTA-01CBPIP-12 Encoding Mismatch of EIP-3009
TTA-02CBPIP-12 Strategy Support Mismatch
TTA-03CInefficient Calldata-Memory Copy
TTA-04CInefficient Iterator Increments
TTA-05CInefficient TLOAD Operations
TTA-06CModifier-Style Usage Support