Manual Review

A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Boson Protocol's BPIP-12 and BPIP-13 implementations.

As the code delta reviewed implements changes supporting token-transfer authorization strategies as well as commit-and-redeem mechanisms, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within BPIP-12 and BPIP-13 without affecting existing processes.

We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed the absence of DAI-specific permit flows within the system in addition to several inconsistencies across the BPIP specifications and their implementation within the code.

Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend the previously established comments of the commit and redeem logic to be re-instated within the refactored base contracts (ExchangeCommitBase and ExchangeRedeemBase).

A total of 15 findings were identified over the course of the manual review of which 3 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.

The finding table below enumerates all these security / behavioural findings:

ID	Severity	Addressed	Title
ECF-01M			Inexistent Re-Entrancy Protection
TTA-01M			Potentially Restrictive Panic
TTA-02M			Inexistent Support of DAI Permit