Omniscia DappRadar Audit
Staking Contracts Security Audit
Audit Overview
We were tasked with performing an audit of the DappRadar codebase and in particular their staking contract implementation.
Over the course of the audit, we identified an incorrect compounding reward mechanism as well as improper dilution of rewards in the reward calculations of the RadarStakingLogic contract.
We advise the DappRadar team to closely evaluate all minor-and-above findings identified in the report and promptly remediate them as well as consider all optimizational exhibits identified in the report.
Post-Audit Conclusion
The DappRadar team iterated through all findings within the report and provided us with a revised commit hash to evaluate all exhibits on.
We evaluated all alleviations performed by DappRadar and have identified that certain exhibits have not been adequately dealt with. We advise the DappRadar team to revisit the following exhibits: RTN-01C, RSL-05C, RSL-05S, RSL-03C, RSL-03S, RSL-01C, RSL-04C, RSL-01M, RSL-02C, RSL-01S, RSE-05C, RSE-01S, RSE-01C, RSE-04C, RSE-03C, RSE-03S, RSE-02C
Post-Audit Conclusion (9193d77dde)
We evaluated all alleviations performed by DappRadar in the latest iteration of the codebase and have identified that all non-informational exhibits have been adequately dealt.
While certain informational exhibits remain unaddressed, they are not related to the security of the project and can thus be safely ignored.
Contracts Assessed
| Files in Scope | Repository | Commit(s) |
|---|---|---|
| RadarStake.sol (RSE) | staking-smart-contracts-evm | 5bdee57329, 8614454f02, 9193d77dde |
| RadarToken.sol (RTN) | staking-smart-contracts-evm | 5bdee57329, 8614454f02, 9193d77dde |
| RadarStakingLogic.sol (RSL) | staking-smart-contracts-evm | 5bdee57329, 8614454f02, 9193d77dde |
Audit Synopsis
| Severity | Identified | Alleviated | Partially Alleviated | Acknowledged |
|---|---|---|---|---|
 | 0 | 0 | 0 | 0 |
 | 13 | 2 | 0 | 11 |
 | 5 | 4 | 1 | 0 |
 | 3 | 3 | 0 | 0 |
 | 1 | 1 | 0 | 0 |
During the audit, we filtered and validated a total of 8 findings utilizing static analysis tools as well as identified a total of 14 findings during the manual review of the codebase. We strongly recommend that any minor severity or higher findings are dealt with promptly prior to the project's launch as they can introduce potential misbehaviours of the system as well as exploits.
The list below covers each segment of the audit in depth and links to the respective chapter of the report: