MerkleDistributor Code Style Findings

MDR-01C: Inexistent Error Message

Description:

The linked require check has no error message explicitly defined.

Example:

Copy
115require(block.timestamp <= vestingUntil);

Recommendation:

We advise one to be set so to aid in the validation of the require's condition as well as the legibility of the codebase.

Alleviation:

An error message was properly defined for the linked statement.

MDR-02C: Redundant Contract Variable

Description:

The linked variable remains unutilized in the code.

Example:

Copy
19address public rewardPool;

Recommendation:

We advise it to be safely omitted.

Alleviation:

The variable was safely omitted from the codebase.

MDR-03C: Variable Mutability Specifiers

Description:

The linked variables are assigned to only once during the contract's constructor.

Example:

Copy
37constructor(
38    address token_,
39    uint256 total_,
40    bytes32 merkleRoot_
41) {
42    vestingStart = block.timestamp;
43    vestingUntil = block.timestamp + VESTING;
44    token = token_;
45    merkleRoot = merkleRoot_;
46    rewardPool = address(0);
47    totalLeft = total_;
48}

Recommendation:

We advise them to be set as immutable greatly optimizing the codebase.

Alleviation:

All referenced variables were properly set as immutable.