Dispatch Static Analysis Findings

DHC-01S: Inexistent Sanitization of Input Addresses

Type	Severity	Location
Input Sanitization		Dispatch.sol:L39-L53

Description:

The linked function(s) accept address arguments yet do not properly sanitize them.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
39constructor(
40    address _yieldAggregatorVaultModule,
41    address _rewardsModule,
42    address _hooksModule,
43    address _feeModule,
44    address _strategyModule,
45    address _withdrawalQueueModule
46) {
47    yieldAggregatorVaultModule = _yieldAggregatorVaultModule;
48    rewardsModule = _rewardsModule;
49    hooksModule = _hooksModule;
50    feeModule = _feeModule;
51    strategyModule = _strategyModule;
52    withdrawalQueueModule = _withdrawalQueueModule;
53}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that each address specified is non-zero.

Alleviation:

The Euler Finance team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.