YieldAggregatorFactory Static Analysis Findings

YAF-01S: Inexistent Sanitization of Input Address

Type	Severity	Location
Input Sanitization		YieldAggregatorFactory.sol:L23-L25

Description:

The linked function accepts an address argument yet does not properly sanitize it.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
23constructor(address _yieldAggregatorImpl) {
24    yieldAggregatorImpl = _yieldAggregatorImpl;
25}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that the address specified is non-zero.

Alleviation:

The Euler Finance team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.