SwapHandlerCombinedBase Static Analysis Findings

SHC-01S: Inexistent Sanitization of Input Addresses

Type	Severity	Location
Input Sanitization		SwapHandlerCombinedBase.sol:L14-L17

Description:

The linked function(s) accept address arguments yet do not properly sanitize them.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
14constructor(address uniSwapRouterV2_, address uniSwapRouterV3_) {
15    uniSwapRouterV2 = uniSwapRouterV2_;
16    uniSwapRouterV3 = uniSwapRouterV3_;
17}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that each address specified is non-zero.

Alleviation:

The Euler Finance team evaluated this exhibit but opted to retain the current code in place as the contracts can be re-deployed in case a misconfiguration in the address input variables was identified. As a result, we consider this exhibit acknowledged.