Omniscia Euler Finance Audit
SwapHandlerUniswapV3 Static Analysis Findings
SwapHandlerUniswapV3 Static Analysis Findings
SHU-01S: Inexistent Sanitization of Input Address
Type | Severity | Location |
---|---|---|
Input Sanitization | SwapHandlerUniswapV3.sol:L12-L14 |
Description:
The linked function accepts an address
argument yet does not properly sanitize it.
Impact:
The presence of zero-value addresses, especially in constructor
implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.
Example:
contracts/swapHandlers/SwapHandlerUniswapV3.sol
12constructor(address uniSwapRouterV3_) {13 uniSwapRouterV3 = uniSwapRouterV3_;14}
Recommendation:
We advise some basic sanitization to be put in place by ensuring that the address
specified is non-zero.
Alleviation:
The Euler Finance team evaluated this exhibit but opted to retain the current code in place as the contracts can be re-deployed in case a misconfiguration in the address
input variables was identified. As a result, we consider this exhibit acknowledged.