Omniscia Gnosis Guild Audit
GPv2Order Code Style Findings
GPv2Order Code Style Findings
GPO-01C: Generic Typographic Mistake
| Type | Severity | Location |
|---|---|---|
| Code Style |  | GPv2Order.sol:L103 |
Description:
The referenced line contains a typographical mistake (i.e. private variable without an underscore prefix) or generic documentational error (i.e. copy-paste) that should be corrected.
Example:
contracts/cowProtocol/libraries/GPv2Order.sol
103/// proceeds should the owner of the order.Recommendation:
We advise this to be done so to enhance the legibility of the codebase.
Alleviation (da3062f6b3ff452092a0b6daa6f226f0f3b696c6):
The Gnosis Guild team evaluated this exhibit and considered out-of-scope as it relates to the Cowswap codebase which the Gnosis Guild team wishes to leave as untouched as possible.
To this end, we consider this exhibit as safely acknowledged by the Gnosis Guild team given that they do not intend to deploy the contract directly but rather interact with it.